Skip to content

fix: Rename built in shadowing variables #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 12, 2024
Merged

fix: Rename built in shadowing variables #1257

merged 5 commits into from
Jun 12, 2024

Conversation

@AlejandroFernandezLuces
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces commented Jun 12, 2024 •
edited
Loading

Description

Fixes shadowing caused by visualization-interface. Fixed in ansys/ansys-tools-visualization-interface#75

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added the bug Something isn't working label Jun 12, 2024
@codecov
Copy link

codecov bot commented Jun 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.07%. Comparing base (57913a2) to head (5664a74).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1257   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files          85       85           
  Lines        6572     6572           
=======================================
  Hits         6051     6051           
  Misses        521      521

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the maintenance Package and maintenance related label Jun 12, 2024
@AlejandroFernandezLuces
Copy link
Contributor Author

AlejandroFernandezLuces commented Jun 12, 2024

Everything seems to be working fine @RobPasMue , feel free to review 🙂

@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review June 12, 2024 10:57
@AlejandroFernandezLuces AlejandroFernandezLuces requested a review from a team as a code owner June 12, 2024 10:57
RobPasMue
RobPasMue requested changes Jun 12, 2024
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my suggestion - LGTM

@RobPasMue RobPasMue enabled auto-merge (squash) June 12, 2024 11:06
@RobPasMue RobPasMue merged commit 98caeee into main Jun 12, 2024
@RobPasMue RobPasMue deleted the fix/builtin-shadowing branch June 12, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@AlejandroFernandezLuces AlejandroFernandezLuces

Labels

bug Something isn't working maintenance Package and maintenance related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlejandroFernandezLuces @RobPasMue @pyansys-ci-bot